Connect with me
Search
Twitter Feed
Navigation
« Weekly Training - Debugging in Visual Studio 2008 | Main | Test web pages in different versions of IE with IETester »
Monday
Jul072008

Concise Code - Does it make things hard to read?

I was using Resharper 4 and noticed some nice code cleanup advise that it gives. One to note it the compression of:

// Create job if quote is won
if (CurrentQuote.Status == "A")
{
    quoteView.FindControl("btnCreateJobCard").Visible = true;
}
else
{
    quoteView.FindControl("btnCreateJobCard").Visible = false;
}

To the one liner (which I prefer)

// Create job if quote is won
quoteView.FindControl("btnCreateJobCard").Visible = CurrentQuote.Status == "A";

I like short succinct code. I think the shortened form is better, but I know some people need to do a double take to see what it’s trying to do.

I would love to hear your opinions on this.

Reader Comments

There are no comments for this journal entry. To create a new comment, use the form below.

PostPost a New Comment

Enter your information below to add a new comment.

My response is on my own website »
Author Email (optional):
Author URL (optional):
Post:
 
Some HTML allowed: <a href="" title=""> <abbr title=""> <acronym title=""> <b> <blockquote cite=""> <code> <em> <i> <strike> <strong>